Make topics persistent between writer's close() and open() API calls. #2229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning: Can be useful when creating topics via direct rosbag2_transport API or initiating close() and open() multiple times. Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
changed the title
MichaelOrlov
requested review from
christophebedard,
emersonknapp and
fujitatomoya
Contributor
Author
|
This PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes topics persistent between writer's close() and open() API calls.
Reasoning:
Will be useful when creating topics via direct
rosbag2_transportAPI or when callingWriter::close()andWriter::open()multiple times.Is this user-facing behavior change?
Yes.
Writer::create_topic(..)andWriter::remove_topic(..)will not throw exceptions if the writer is not open.Did you use Generative AI?
Yes. I used GitHub Copilot, GPT-4.o to help with writing unit tests and Doxygen comments.
Additional Information
No API/ABI changes. This PR can be backported.